Fuzzy Search / Javascript Fehler / Jquery Uncaught Exception ->FIX

Duplicate julien

Hallo,

nachdem ich den Sontag liebend draussen als vorm Computer sitzen wollte, leider aber dass nicht schaffte

Poste ich hier meine neue Entdeckung und Lösung.

Die Fuzzy Search ist, na ja..ein bisschen unlogisch gebaut.

Ok, es gibt 2 fuzzy_search, eine in includes/modules, eine in includes/modules/classes wieso auch immer(könnte ich bis jetzt nicht nachvollziehen) wird in der erste die Class Fuzzy_search ncohmals definiert statt inkludiert?

1) Here we go..., dann löschen bis es so aussieht:

Code

// wenn keywords aus Suche übergeben -> fuzzy search
if (($_GET['keywords']) && (SEARCH_ACTIVATE_SUGGEST == 'true')){


  require_once (DIR_FS_INC.'xtc_get_products_image.inc.php');
  require_once (DIR_WS_CLASSES.'fuzzy_search.php');


	$keywords = strtolower($_GET['keywords']);


	$Suggest = new FuzzySearch();
	$Suggest->getSuggest($keywords);
	$module_content_keywords = $Suggest->resultKeywords;
	$module_content_products = $Suggest->new_fuzzy;
	$parse_time = $Suggest->parse_time;


	if($module_content_keywords)
		$module_smarty->assign('keyword_data', $module_content_keywords);


	if ($module_content_products){
		$info_smarty = new Smarty;
		$info_smarty->assign('tpl_path','templates/'.CURRENT_TEMPLATE.'/');
		$info_smarty->assign('language', $_SESSION['language']);
		$info_smarty->assign('module_content', $module_content_products);
                $info_smarty->assign('CLASS', 'product_listing');//JS SCRIPT ERROR WENN NICHT VORHANDEN
		$info_smarty->caching = 0;
		$module_smarty->assign('suggest_products', $info_smarty->fetch(CURRENT_TEMPLATE.'/module/product_listings.html'));
	} 


	if (SEARCH_SHOW_PARSETIME == 'true')
		$module_smarty->assign('PARSE_TIME', '<small>'.$parse_time.' s</small>');    
}

Alles anzeigen

Damit hätten wir ein bisschen aufgeräumt.

2) Die includes/classes/fuzzy_search.php sieht auch nicht so doll aus...also ersetzen mit:

Code

class FuzzySearch {


	 	var $keywords;
	 	var $resultKeywords = array();
	 	var $resultProducts = array();
		var $new_fuzzy = array();
	 	var $parse_time;


		function getSpecialChars($str){
			$string = strip_tags($str);
			$trans = get_html_translation_table (HTML_ENTITIES);
			$trans = array_flip($trans);
			$string = strtr($string, $trans);


			return $string;
		}


		function getSuggest($keywords) {
	 		// Vorbereitungen
	    	global $xtPrice;
			define('PARSE_START_TIME', microtime());


			$weight_sum = (SEARCH_WEIGHT_LEVENSHTEIN + SEARCH_WEIGHT_SIMILAR_TEXT + SEARCH_WEIGHT_METAPHONE);
			if ($weight_sum > 100){
			 	define('SEARCH_WEIGHT_LEVENSHTEIN', (SEARCH_WEIGHT_LEVENSHTEIN/$weight_sum)*100);
			 	define('SEARCH_WEIGHT_SIMILAR_TEXT', (SEARCH_WEIGHT_SIMILAR_TEXT/$weight_sum)*100);
			 	define('SEARCH_WEIGHT_METAPHONE', (SEARCH_WEIGHT_METAPHONE/$weight_sum)*100);
			}


	    	if (SEARCH_WEIGHT_METAPHONE > 0)
	    		$keyword_metaphone = metaphone(xtc_db_input($keywords));


	    	$keyword_lev_sim = xtc_db_input($keywords);
	    	$colors = explode(';',SEARCH_PROXIMITY_COLORS);


	//fsk18 lock
	  	if ($_SESSION['customers_status']['customers_fsk18_display'] == '0') {
		   	$fsk_lock = " AND p.products_fsk18 != '1' ";
		  } else {
			  unset ($fsk_lock);
		  }


	//group check
	  	if (GROUP_CHECK == 'true') {
		   	$group_check = " AND p.group_permission_".$_SESSION['customers_status']['customers_status_id']."=1 ";
		  } else {
			  unset ($group_check);
		  }


	// search in keywords?
	    if (SEARCH_PRODUCT_KEYWORDS == 'true'){
	      $search_keywords =', pd.products_keywords ';
	    } else {
			  unset ($search_keywords);
		  }


	// search in description?
	    if (SEARCH_PRODUCT_DESCRIPTION == 'true'){
	      $search_description =', pd.products_short_description, pd.products_description ';
	    } else {
			  unset ($search_description);
		  }




	// alle Produktnamen holen
			$sql = "SELECT pd.products_name".$search_keywords.$search_description."
					FROM ".TABLE_PRODUCTS." AS p 
					LEFT JOIN ".TABLE_PRODUCTS_DESCRIPTION." AS pd ON (p.products_id = pd.products_id)
					LEFT JOIN ".TABLE_PRODUCTS_TO_CATEGORIES." AS pc ON (p.products_id = pc.products_id) 
					LEFT JOIN ".TABLE_CATEGORIES." AS c ON (pc.categories_id = c.categories_id)
					WHERE 
					p.products_status = '1'
					AND c.categories_status = 1
					AND pd.language_id = '".(int) $_SESSION['languages_id']."'".$fsk_lock.$group_check;
	        $product_query = xtc_db_query($sql);


	        $max_count=0;
	        $results['name'] = array();
	        $results['proximity_color'] = array();


	// jeden Produktnamen durchlaufen
	        while($product_array = xtc_db_fetch_array($product_query)) {


	// Schlagwortstring zusammensetzen
	        $word_string = $product_array['products_name'];
	        if (SEARCH_PRODUCT_KEYWORDS == 'true')
	          $word_string .= ' '.$product_array['products_keywords'];
	        if (SEARCH_PRODUCT_DESCRIPTION == 'true')
	          $word_string .= ' '.$this->getSpecialChars($product_array['products_short_description']).' '.$this->getSpecialChars($product_array['products_description']);


	// Strings zerlegen 
	          if ((SEARCH_SPLIT_PRODUCT_NAMES == 'true')||(SEARCH_PRODUCT_KEYWORDS == 'true')||(SEARCH_PRODUCT_DESCRIPTION == 'true')){
	            $split_content = preg_split("/".SEARCH_SPLIT_PRODUCT_CHARS."+/", $word_string);
	          } else {
	            $split_content[0] = $word_string;        
	          }


	// Schleife um gesplitte Namen zu prРЎРЉfen starten bix maximale Ergebnisse vorhanden sind      
	          $count=0;
	          foreach ($split_content as $split_names){
	          $split_names = trim($split_names);
	// wenn split keine Zahl und LР*Т‘nger als X Zeichen
	            if (strlen($split_names)> SEARCH_SPLIT_MINIMUM_LENGTH){


	// NР*Т‘he mit similar_text, levenshtein und/oder metaphone prРЎРЉfen 
	              if (SEARCH_WEIGHT_LEVENSHTEIN > 0)
	                $prl = 100 -(10*levenshtein ($keyword_lev_sim, strtolower($split_names)));


	              if (SEARCH_WEIGHT_SIMILAR_TEXT > 0)
	                similar_text($keyword_lev_sim, strtolower($split_names),$prs);


	              if (SEARCH_WEIGHT_METAPHONE > 0)
	                similar_text($keyword_metaphone, metaphone($split_names),$prm);


	// Р*В¬bereinstimmung berechnen              
	              $pr = ($prl*SEARCH_WEIGHT_LEVENSHTEIN/100)+($prs*SEARCH_WEIGHT_SIMILAR_TEXT/100)+($prm*SEARCH_WEIGHT_METAPHONE/100);


	              if (($pr > SEARCH_PROXIMITY_TRIGGER) && (!in_array($split_names, $results['name']))) {
				          $proximity = sprintf('%01.0f', $pr);
	                $results['name'][$max_count] = $split_names;
				          $results['proximity'][$max_count] = $proximity;




	// Farbabstufungen berechnen
	                if (SEARCH_ENABLE_PROXIMITY_COLOR == 'true'){
	                  if ($results['proximity'][$max_count] < 60) $proximity_color = $colors[4];
	                  if ($results['proximity'][$max_count] >= 60) $proximity_color = $colors[3];
	                  if ($results['proximity'][$max_count] >= 70) $proximity_color = $colors[2];
	                  if ($results['proximity'][$max_count] >= 80) $proximity_color = $colors[1];
	                  if ($results['proximity'][$max_count] >= 90) $proximity_color = $colors[0];   
				            $results['proximity_color'][$max_count] = $proximity_color;
	                } else {
	                  $results['proximity_color'] = array();
	                }
				          $max_count++;
	              }
	            }
	         }
	      }


	// Wenn Ergebnisse vorhanden, $results nach NР*Т‘he sortieren und ausgeben
	    if ($max_count > 0){
	    if (SEARCH_ENABLE_PROXIMITY_COLOR == 'true'){
	      array_multisort ($results['proximity'], SORT_NUMERIC,SORT_DESC, $results['name'], SORT_ASC, SORT_STRING, $results['proximity_color'], SORT_ASC, SORT_STRING );
	      } else {
	      array_multisort ($results['proximity'], SORT_NUMERIC,SORT_DESC, $results['name'], SORT_ASC, SORT_STRING);
	      }      
	      $counter=0;
	      while ($results['name'][$counter] && $counter < SEARCH_MAX_KEXWORD_SUGGESTS){


	// Produktanzahl zum Keyword ermitteln?
	        if (SEARCH_COUNT_PRODUCTS == 'true'){


	// search in keywords?
	          if (SEARCH_PRODUCT_KEYWORDS == 'true'){
	            $count_keywords =" OR pd.products_keywords LIKE ('%".addslashes($results['name'][$counter])."%')";
	          } else {
			        unset ($count_keywords);
		        }


	// search in description?
	          if (SEARCH_PRODUCT_DESCRIPTION == 'true'){
	            $count_description =" OR pd.products_short_description LIKE ('%".addslashes(htmlentities($results['name'][$counter]))."%')";
	            $count_description .=" OR pd.products_description LIKE ('%".addslashes(htmlentities($results['name'][$counter]))."%')";
	          } else {
			        unset ($count_description);
		        }


	          $products_count_query = xtc_db_query("SELECT COUNT(*) as 'products_count' FROM ".TABLE_PRODUCTS." AS p LEFT JOIN ".TABLE_PRODUCTS_DESCRIPTION." AS pd ON (p.products_id = pd.products_id)
	                                                WHERE p.products_status = '1'
					                                        AND pd.language_id = '".(int) $_SESSION['languages_id']."'".$fsk_lock.$group_check." 
	                                                AND ( pd.products_name LIKE ('%".addslashes($results['name'][$counter])."%')".$count_keywords.$count_description.")");
	          $products_counter = xtc_db_fetch_array($products_count_query);
	          $results['products_count'][$counter] = $products_counter['products_count'];
	        }


	// ins Array        
	        $this->resultKeywords[$counter] =array ('SUGGEST_KEYWORD' => $results['name'][$counter],
	                                                   'SUGGEST_PROXIMITY' => $results['proximity'][$counter].'%',
	                                                   'SUGGEST_COUNT' => $results['products_count'][$counter],
	                                                   'SUGGEST_COLOR' => $results['proximity_color'][$counter],
	                                                   'SUGGEST_LINK' => xtc_href_link(FILENAME_ADVANCED_SEARCH_RESULT, 'keywords='.urlencode($results['name'][$counter])));
	        $counter++;
	      }


	// jetzt noch ein paar Produkte finden  
	     if (SEARCH_ENABLE_PRODUCTS_SUGGEST == 'true'){
	        $counter = 0;
	        $row = 0;
	        while ($counter < SEARCH_MAX_PRODUCTS_SUGGEST){


	// search in keywords?
	          if (SEARCH_PRODUCT_KEYWORDS == 'true')
	            $count_keywords =" OR pd.products_keywords LIKE ('%".addslashes($results['name'][$counter])."%')";
	          else
			  	unset ($count_keywords);


	// search in description?
	          if (SEARCH_PRODUCT_DESCRIPTION == 'true'){
	            $count_description =" OR pd.products_short_description LIKE ('%".addslashes(htmlentities($results['name'][$counter]))."%')";
	            $count_description .=" OR pd.products_description LIKE ('%".addslashes(htmlentities($results['name'][$counter]))."%')";
	          } else {
			        unset ($count_description);
		        }


	          $products_suggest_query = xtc_db_query("SELECT DISTINCT 
														pd.products_name, 
														p.products_id, 
														p.products_image,
														p.products_price, 
														p.products_tax_class_id, 
														pd.products_id, 
														cd.categories_id, 
														cd.categories_name, 
														ptc.categories_id
													FROM 
														((products AS p LEFT JOIN products_description AS pd ON (p.products_id = pd.products_id))
													INNER JOIN 
														".TABLE_PRODUCTS_TO_CATEGORIES." AS ptc ON (p.products_id = ptc.products_id)) 
													INNER JOIN 
														".TABLE_CATEGORIES_DESCRIPTION." AS cd ON (ptc.categories_id = cd.categories_id)
													WHERE 
														p.products_status = '1'
													AND 
														pd.language_id = '".(int) $_SESSION['languages_id']."'".$fsk_lock.$group_check."
													AND 
														( pd.products_name LIKE ('%".addslashes($results['name'][$counter])."%')".$count_keywords.$count_description.")
													LIMIT 
														".(SEARCH_MAX_PRODUCTS_SUGGEST-$counter));

			if(!is_object($product))
				$product = new product();
	        while($products_suggest = xtc_db_fetch_array($products_suggest_query, true)) {
	            if (($counter <= SEARCH_MAX_PRODUCTS_SUGGEST) && ($results['name'][$row])){ $ii++;
	            $this->results[$counter] = array ('PRODUCTS_NAME' => $products_suggest['products_name'],
	                                                        'CATEGORIES_NAME' => $products_suggest['categories_name'],
	                                                        'CATEGORIES_LINK' => xtc_href_link(FILENAME_DEFAULT, xtc_category_link($products_suggest['categories_id'],$products_suggest['categories_name'])),
	                                                        'PRODUCTS_PROXIMITY' => $results['proximity'][$row].'%',
	                                                        'PRODUCTS_PROXIMITY_COLOR' => $results['proximity_color'][$row]);

					$this->resultProducts[$counter] = $product->buildDataArray($products_suggest, 'thumbnail', 'fuzzy_search', $ii);
					$this->new_fuzzy[$counter] = array_merge($this->resultProducts[$counter], $this->results[$counter]);
	            }
	            $counter++;
	          }
	          $row++;
	        }
	      }
	    } 


	// Parsetime berechnen
	    if (SEARCH_SHOW_PARSETIME == 'true'){
	      $time_start = explode(' ', PARSE_START_TIME);
	      $time_end = explode(' ', microtime());
	      $this->parse_time = number_format(($time_end[1] + $time_end[0] - ($time_start[1] + $time_start[0])), 3);  
	  }
	  return;
	 }


	}

Alles anzeigen

ohne include oder include_once!

3) Jetzt JS and JQUERY. Der grund meinen verlorenen So.nachmittag...
In der templates/.../module/product_listing.html werden mehrmals JQUERY aufrufe gemacht unter anderem dieser code ist von Bedeutung!!

Code

$('#{/literal}{$CLASS}{literal} li').each(function(e) {

Und da liegt der hacken...klein, fast unsichbar...dennoch aber produziert er eine hässliche Fehlermeldung (im demoshop zu sehen wenn man irgendwie die product_listing.html benötigt)
Aslo..auch gesehen?? Ja!! DER! Dieser $(/&%(/%& LEERZEICHEN!!!
Also, um sicher zu sein muss man das ganze umbauen...sodass es klappt wenn $CLASS existiert oder auch nicht... fertig sieht dann so aus...

Code

{literal}
<script type="text/javascript">
    var max_height = 0;  
    {/literal}{if isset($CLASS)}{literal}
    $('#{/literal}{$CLASS}{literal} li').each(function(e) { 
    {/literal}{else}{literal}
    $('#li').each(function(e) { 
    {/literal}{/if}{literal} 
      h = $(this).height();  
      if(typeof(h) != "undefined") {  
            if(h > max_height) {  
                    max_height = h+10;  
            }  
      }  
    });  
    if(max_height > 0) { 
    {/literal}{if isset($CLASS)}{literal} 
     $('#{/literal}{$CLASS}{literal} li').height(max_height); 
     {/literal}{else}{literal}
     $('#li').height(max_height);  
     {/literal}{/if}{literal}
    }  
</script>
{/literal}

Alles anzeigen

diese Logik in jeden Aufruf einbauen und schon darf man sich auf Fehlerfreie Seite freuen...

Jetzt aber, ab nach draussen.

Julien.

admin

Dürfte ich mal erwähnen, dass Du ein Held bist Danke. Habe es gleich getestet und im QF3 mit auf genommen. Mit dem Merkzettel habe ich auch noch einen Fix gefunden, wird dann auch mit drin sein. Allerdings forschen wir noch weiter, da kann noch ein update kommen. Ich denke, julien, der hier auch hervoragende Arbeit geleistet hat, ist da auch noch dran.

Benutzer online in diesem Thema